Re: RFR: 8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar

2021-05-26 Thread Roger Riggs
On Tue, 25 May 2021 16:40:53 GMT, Naoto Sato wrote: > Please review the fix. The issue was informed yesterday by @amaembo that it > offends some code analysis tools. > Although the fix is to change the condition error, it turned out that > `JapaneseImperialCalendar.roll()` did not work for `WEE

Integrated: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current

2021-05-26 Thread Naoto Sato
On Mon, 17 May 2021 16:55:35 GMT, Naoto Sato wrote: > Please review the changes to the subject issue. java.util.Locale class has a > long-standing issue for those obsolete ISO 639 languages where its > normalization ends up in the obsolete codes. This change intends to flip the > normalization

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v7]

2021-05-26 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v6]

2021-05-26 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the las

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v5]

2021-05-26 Thread Daniel Fuchs
On Wed, 26 May 2021 09:39:44 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.io`, >> `java.math`, and `java.text` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v5]

2021-05-26 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v4]

2021-05-26 Thread Patrick Concannon
On Wed, 26 May 2021 09:05:34 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.io`, >> `java.math`, and `java.text` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v4]

2021-05-26 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.io`, > `java.math`, and `java.text` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the las

Re: RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions [v2]

2021-05-26 Thread Patrick Concannon
On Tue, 25 May 2021 15:18:46 GMT, Chris Hegarty wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>