Re: RFR: 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.” phrase

2021-04-08 Thread Joe Wang
On Thu, 8 Apr 2021 18:19:20 GMT, Naoto Sato wrote: > Please review the fix to the subject issue. It is not actually related to > "parenthesized", but period-comma sequence was regarded as a break on a > backward traverse. Marked as reviewed by joehw (Reviewer). - PR: https://git.

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v3]

2021-04-08 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webre

Re: RFR: 8264896: Remove redundant '& 0xFF' from int-to-byte cast

2021-04-08 Thread Daniel Fuchs
On Thu, 8 Apr 2021 08:54:35 GMT, Sebastian Stenzel wrote: >> When we do >> byte b1 = (byte) (value & 0xFF); >> we keep from int only 1 lower byte and exactly the same can be achieved with >> plain cast. See the test below: >> public class Main { >> public static void main(String[] args) throw

Re: RFR: 8264896: Remove redundant '& 0xFF' from int-to-byte cast

2021-04-08 Thread Sebastian Stenzel
On Thu, 4 Mar 2021 12:16:29 GMT, Сергей Цыпанов wrote: > When we do > byte b1 = (byte) (value & 0xFF); > we keep from int only 1 lower byte and exactly the same can be achieved with > plain cast. See the test below: > public class Main { > public static void main(String[] args) throws Excepti

Re: RFR: 8263561: Re-examine uses of LinkedList

2021-04-08 Thread Сергей Цыпанов
On Mon, 15 Mar 2021 06:56:00 GMT, Alan Bateman wrote: >> Nothing outside of the JDK should be hacking into this private field of a >> non-exposed class, this should not be a concern here. > >> @AlanBateman so is it ok to keep `ArrayLists`? > > One thing to look out for is usages of 2-arg add me

RFR: 8264896: Remove redundant '& 0xFF' from int-to-byte cast

2021-04-08 Thread Сергей Цыпанов
When we do byte b1 = (byte) (value & 0xFF); we keep from int only 1 lower byte and exactly the same can be achieved with plain cast. See the test below: public class Main { public static void main(String[] args) throws Exception { IntStream.range(Integer.MIN_VALUE, Integer.MAX_VALUE).forEach