Integrated: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-03-30 Thread Joe Darcy
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining This pull request has now been integrated. Changeset: 815248ab Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/815248ab Stats: 84 lines in 22

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-03-30 Thread Stuart Marks
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining Marked as reviewed by smarks (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3182

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-03-30 Thread Joe Darcy
On 3/30/2021 6:29 AM, Roger Riggs wrote: On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: 8264148: Update spec for exceptions retrofitted for exception chaining I agree that the public field in WriteAbortedException could be remediated. But it is also mostly harmless. src/jdk.hotspot.age

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-03-30 Thread Joe Darcy
On 3/30/2021 6:43 AM, jmehrens wrote: On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: 8264148: Update spec for exceptions retrofitted for exception chaining src/java.base/share/classes/java/io/WriteAbortedException.java line 86: 84: @Override 85: public Throwable getCause() { 8

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-03-30 Thread jmehrens
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining src/java.base/share/classes/java/io/WriteAbortedException.java line 86: > 84: @Override > 85: public Throwable getCause() { > 86: return detail; Use Suppr

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-03-30 Thread Roger Riggs
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining I agree that the public field in WriteAbortedException could be remediated. But it is also mostly harmless. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VMO