Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]

2021-03-25 Thread Phil Race
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > bro

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]

2021-03-25 Thread Iris Clark
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > bro

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]

2021-03-25 Thread Kevin Rushforth
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > bro

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]

2021-03-25 Thread Andy Herrick
On Wed, 17 Mar 2021 20:33:09 GMT, Andy Herrick wrote: >>> I cannot find any instances where the scope can be narrowed >> >> Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. >> stateChanged, and other non-trivial methods? > >> >> >> > I cannot find any instances where the scop

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]

2021-03-25 Thread Andy Herrick
> implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 301 additi

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-25 Thread Kevin Rushforth
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal src/java.desktop/share/classes/java/applet/package-info.java line 39: > 37: * applet development environment. > 38: * > 39: * @deprecated. This package has

RFR: 8262110: DST starts from incorrect time in 2038

2021-03-25 Thread Naoto Sato
Please review the fix to the DST transition bug after the year 2037. The logic had the side effect that it adjusted the dst offset every time the method `getOffsets()` is issued. Only adjust the offset when issued with wall time. - Commit messages: - Set time zone to the formatter.

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v2]

2021-03-25 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.time` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webre