Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Wed, 17 Mar 2021 19:02:39 GMT, Alan Bateman wrote: > > > > I cannot find any instances where the scope can be narrowed > > Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. > stateChanged, and other non-trivial methods? These have the code pattern such as: } else if (c in

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Alan Bateman
On Wed, 17 Mar 2021 16:44:19 GMT, Andy Herrick wrote: > I cannot find any instances where the scope can be narrowed Are you about AquaInternalFrameUI.mouseRelased, BasicPopupMenuUI. stateChanged, and other non-trivial methods? - PR: https://git.openjdk.java.net/jdk/pull/2920

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Sun, 14 Mar 2021 12:06:08 GMT, Alan Bateman wrote: > > > Have you looked at narrowing the use of the SuppressWarnings to local > variable declarations to avoid adding it to some of these methods? in all cases either: - the class or method itself is being deprecated - the method takes a d

Withdrawn: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote: > implementation of > JDK-8256145: JEP 398: Deprecate the Applet API for Removal This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/2920

Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations

2021-03-17 Thread Andy Herrick
On Sun, 14 Mar 2021 12:06:08 GMT, Alan Bateman wrote: > the - PR: https://git.openjdk.java.net/jdk/pull/2920

Integrated: 8263677: Improve Character.isLowerCase/isUpperCase lookups

2021-03-17 Thread Claes Redestad
On Tue, 16 Mar 2021 12:51:02 GMT, Claes Redestad wrote: > This patch changes the otherLowercase / otherUppercase bits to be set if > either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or the > Unicode Other_Lowercase / Other_Uppercase property is set. This simplifies > the

Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups [v2]

2021-03-17 Thread Roger Riggs
On Tue, 16 Mar 2021 21:02:28 GMT, Claes Redestad wrote: >> This patch changes the otherLowercase / otherUppercase bits to be set if >> either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or >> the Unicode Other_Lowercase / Other_Uppercase property is set. This >> simplifies

Re: RFR: 8263658: Use the blessed modifier order in java.base

2021-03-17 Thread Roger Riggs
On Sat, 13 Mar 2021 22:45:30 GMT, Alex Blewitt wrote: > Sonar displays a warning message that modifiers should be declared in the > order listed in the JLS; specifically, that isntead of using `final static` > the `static final` should be preferred. > > This fixes the issues in the `java.base

RFR: 8263658: Use the blessed modifier order in java.base

2021-03-17 Thread Alex Blewitt
Sonar displays a warning message that modifiers should be declared in the order listed in the JLS; specifically, that isntead of using `final static` the `static final` should be preferred. This fixes the issues in the `java.base` package for ease of reviewing. https://sonarcloud.io/project/iss

Re: RFR: 8263658: Use the blessed modifier order in java.base

2021-03-17 Thread Aleksey Shipilev
On Sat, 13 Mar 2021 22:45:30 GMT, Alex Blewitt wrote: > Sonar displays a warning message that modifiers should be declared in the > order listed in the JLS; specifically, that isntead of using `final static` > the `static final` should be preferred. > > This fixes the issues in the `java.base