On Mon, 8 Mar 2021 21:25:32 GMT, Ian Graves wrote:
> This fixes a zero-adding issue observed in the hex float conversion.
This pull request has now been integrated.
Changeset: 6971c23a
Author:Ian Graves
Committer: Brent Christian
URL: https://git.openjdk.java.net/jdk/commit/6971c23a
On Wed, 10 Mar 2021 02:31:28 GMT, Ian Graves wrote:
>> This fixes a zero-adding issue observed in the hex float conversion.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updating Formatter copyright date
Marked as reviewed
On Wed, 10 Mar 2021 02:31:28 GMT, Ian Graves wrote:
>> This fixes a zero-adding issue observed in the hex float conversion.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updating Formatter copyright date
Looks good to me.
On Fri, 26 Feb 2021 17:50:19 GMT, Christoph Göttschkes wrote:
> Please review this small patch which fixes the coding style of
> CharacterDataPrivateUse.java
This pull request has now been integrated.
Changeset: c8c0234b
Author:Christoph Göttschkes
Committer: Roger Riggs
URL: https
On Fri, 26 Feb 2021 17:50:19 GMT, Christoph Göttschkes wrote:
> Please review this small patch which fixes the coding style of
> CharacterDataPrivateUse.java
For (most) core-libs changes, only 1 reviewer is required.
However, given the broad interest, please allow time (a day or weekend) for
o
On Mon, 1 Mar 2021 15:21:23 GMT, Christoph Göttschkes wrote:
>> Looks fine. This source file was a .template until a few weeks ago, probably
>> should have fixed the indentation issues when moving it to a .java file.
>
> Thanks for the review.
> Do we need a second reviewer? If not, could you pl
