Integrated: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-22 Thread Dmitry Markov
On Tue, 19 Jan 2021 11:10:35 GMT, Dmitry Markov wrote: > Problem description: > The IME behaviour has changed starting from recent Windows 10 builds. In > particular if the complex characters (Japanese, Chinese, etc.) are entered to > some component and the focus is transferred to another compo

Integrated: 8246788: ZoneRules invariants can be broken

2021-01-22 Thread Stuart Marks
On Fri, 22 Jan 2021 05:39:55 GMT, Stuart Marks wrote: > Tighten up argument checking in constructor. This pull request has now been integrated. Changeset: a8871776 Author:Stuart Marks URL: https://git.openjdk.java.net/jdk/commit/a8871776 Stats: 90 lines in 2 files changed: 87 ins

Re: RFR: 8246788: ZoneRules invariants can be broken

2021-01-22 Thread Stuart Marks
On Fri, 22 Jan 2021 17:12:34 GMT, Daniel Fuchs wrote: >> Or even maybe `rulesArray = >> lastRules.toArray(ZoneOffsetTransitionRule[]::new);`? > > Good point - but that would be: > > ZoneOffsetTransitionRule[] rulesArray = > lastRules.toArray(ZoneOffsetTransitionRule[]::new).clone(); Interesti

Re: RFR: 8246788: ZoneRules invariants can be broken

2021-01-22 Thread Daniel Fuchs
On Fri, 22 Jan 2021 15:00:17 GMT, Florent Guillaume wrote: >> src/java.base/share/classes/java/time/zone/ZoneRules.java line 263: >> >>> 261: // last rules >>> 262: Object[] temp = lastRules.toArray(); >>> 263: ZoneOffsetTransitionRule[] rulesArray = Arrays.copyOf(temp,

Re: RFR: 8246788: ZoneRules invariants can be broken

2021-01-22 Thread Florent Guillaume
On Fri, 22 Jan 2021 14:48:00 GMT, Daniel Fuchs wrote: >> Tighten up argument checking in constructor. > > src/java.base/share/classes/java/time/zone/ZoneRules.java line 263: > >> 261: // last rules >> 262: Object[] temp = lastRules.toArray(); >> 263: ZoneOffsetTransitionR

Re: RFR: 8246788: ZoneRules invariants can be broken

2021-01-22 Thread Naoto Sato
On Fri, 22 Jan 2021 05:39:55 GMT, Stuart Marks wrote: > Tighten up argument checking in constructor. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2191

Re: RFR: 8246788: ZoneRules invariants can be broken

2021-01-22 Thread Daniel Fuchs
On Fri, 22 Jan 2021 05:39:55 GMT, Stuart Marks wrote: > Tighten up argument checking in constructor. src/java.base/share/classes/java/time/zone/ZoneRules.java line 263: > 261: // last rules > 262: Object[] temp = lastRules.toArray(); > 263: ZoneOffsetTransitionRule[] rul

Re: RFR: 8246788: ZoneRules invariants can be broken

2021-01-22 Thread Roger Riggs
On Fri, 22 Jan 2021 05:39:55 GMT, Stuart Marks wrote: > Tighten up argument checking in constructor. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2191

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-22 Thread Ichiroh Takiguchi
On Thu, 21 Jan 2021 21:41:09 GMT, Dmitry Markov wrote: >> Marked as reviewed by aivanov (Reviewer). > >> Hi, >> >> AWT's `TextComponent` is a `peered` input client, and Swing's >> `JTextComponent` is an `active` input client. Thus it is OK to behave >> differently. I would expect that AWT's on