RFR: 8246788: ZoneRules invariants can be broken

2021-01-21 Thread Stuart Marks
Tighten up argument checking in constructor. - Commit messages: - 8246788: ZoneRules invariants can be broken Changes: https://git.openjdk.java.net/jdk/pull/2191/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2191&range=00 Issue: https://bugs.openjdk.java.net/browse/

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-21 Thread Dmitry Markov
On Thu, 21 Jan 2021 21:34:25 GMT, Alexey Ivanov wrote: >> Dmitry Markov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use endComposition() instead of endCompositionNative() > > Marked as reviewed by aivanov (Reviewer). > Hi, > > AWT'

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-21 Thread Alexey Ivanov
On Thu, 21 Jan 2021 13:51:58 GMT, Dmitry Markov wrote: >> Problem description: >> The IME behaviour has changed starting from recent Windows 10 builds. In >> particular if the complex characters (Japanese, Chinese, etc.) are entered >> to some component and the focus is transferred to another c

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Naoto Sato
On Thu, 21 Jan 2021 21:17:53 GMT, Dmitry Markov wrote: >>> > > Now we will commit the composition string if there is an active client. >>> > > That changes eliminates the issue described in JDK-8258805. Also the >>> > > behaviour of AWTTextTest1 is the same as it used to be on the previous >>>

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Dmitry Markov
On Thu, 21 Jan 2021 19:25:16 GMT, Alexey Ivanov wrote: > I admit I am even more confused now. To me, the description in the comment > above is nearly the same as in [JBS > comment](https://bugs.openjdk.java.net/browse/JDK-8258805?focusedCommentId=14391025&page=com.atlassian.jira.plugin.system.i

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Alexey Ivanov
On Thu, 21 Jan 2021 14:54:34 GMT, Dmitry Markov wrote: >>> Now we will commit the composition string if there is an active client. >>> That changes eliminates the issue described in JDK-8258805. Also the >>> behaviour of AWTTextTest1 is the same as it used to be on the previous >>> versions w/

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Dmitry Markov
On Thu, 21 Jan 2021 14:18:43 GMT, Alexey Ivanov wrote: > > Now we will commit the composition string if there is an active client. > > That changes eliminates the issue described in JDK-8258805. Also the > > behaviour of AWTTextTest1 is the same as it used to be on the previous > > versions w/

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Alexey Ivanov
On Thu, 21 Jan 2021 13:47:30 GMT, Dmitry Markov wrote: > Now we will commit the composition string if there is an active client. That > changes eliminates the issue described in JDK-8258805. Also the behaviour of > AWTTextTest1 is the same as it used to be on the previous versions w/o the > fi

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-21 Thread Dmitry Markov
> Problem description: > The IME behaviour has changed starting from recent Windows 10 builds. In > particular if the complex characters (Japanese, Chinese, etc.) are entered to > some component and the focus is transferred to another component (which does > not support the IM) the IM is disable

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Dmitry Markov
On Wed, 20 Jan 2021 12:28:36 GMT, Alexey Ivanov wrote: >>> > Fix: >>> > It is necessary to take care of unconfirmed composition string once the >>> > IME is going to be disabled. >>> >>> The fix commits the unconfirmed composition string. Committing is better >>> than discarding. Is it possibl