On Tue, 8 Dec 2020 06:12:36 GMT, Yumin Qi wrote:
>> Changes requested by iklam (Reviewer).
>
> Please check 03. 02 is generated when merge with most current and remote head
> not updated correctly. After set remote head correct, 03 is regenerated and
> is correct one for review. Thanks
This br
On Mon, 7 Dec 2020 05:01:27 GMT, Yumin Qi wrote:
> Hi, Please review
> Windows mapping for file into memory could not happen to reserved memory.
> In mapping CDS archive we first reserve enough memory then before mapping,
> release them. For cds archive and using class space, need split the w
> Hi, Please review
> Windows mapping for file into memory could not happen to reserved memory.
> In mapping CDS archive we first reserve enough memory then before mapping,
> release them. For cds archive and using class space, need split the whole
> space into two, that is, release the whole
On Fri, 11 Dec 2020 01:25:48 GMT, Naoto Sato wrote:
>> src/java.base/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
>> line 78:
>>
>>> 76: // CalendarData value types
>>> 77: private static final int CD_FIRSTDAYOFWEEK = 0;
>>> 78: private static final in
On Fri, 11 Dec 2020 00:15:49 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added comment for LOCALE_IFIRSTWEEKOFYEAR Windows return values
>
> src/java.base/windows/classes/sun/util/locale/provider/Ho
> Hello,
>
> Please review the changes to the subject issue. getMinimalDaysInFirstWeek()
> for Windows has been implemented to suffice the bug claim.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added comment for LOCALE_IFIRSTWEEKO
On Thu, 10 Dec 2020 21:12:29 GMT, Naoto Sato wrote:
> Hello,
>
> Please review the changes to the subject issue. getMinimalDaysInFirstWeek()
> for Windows has been implemented to suffice the bug claim.
Looks good to me. Some minor comments below.
src/java.base/windows/classes/sun/util/locale/
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
>
Hello,
Please review the changes to the subject issue. getMinimalDaysInFirstWeek() for
Windows has been implemented to suffice the bug claim.
-
Commit messages:
- JDK-8257964
Changes: https://git.openjdk.java.net/jdk/pull/1741/files
Webrev: https://webrevs.openjdk.java.net/?repo=
