Re: RFR: 8253322 : Update the specification in the newly added constructors

2020-09-23 Thread Phil Race
On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov wrote: > Looks like different people use a different style for the new constructors, > it will be good to unify them. > > The text "Constructor for subclasses to call." should be used in the > protected constructors in the abstract classes > In

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package [v5]

2020-09-23 Thread Vladimir Kozlov
On Wed, 23 Sep 2020 20:02:45 GMT, Erik Gahlin wrote: >> Philippe Marschall has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now >> contains one commit: >> 8138732: Rename HotSpotIntrinsicCandidate to IntrinsicCandidate > > Marked as reviewed b

Re: RFR: 8253322 : Update the specification in the newly added constructors

2020-09-23 Thread Sergey Bylokhov
On Wed, 23 Sep 2020 19:31:28 GMT, Phil Race wrote: > otherwise where will be the record other than the scattered changes > themselves ? > Please summarise along those lines. The description is updated. - PR: https://git.openjdk.java.net/jdk/pull/315

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package [v5]

2020-09-23 Thread Erik Gahlin
On Wed, 23 Sep 2020 18:41:06 GMT, Philippe Marschall wrote: >> Hello, newbie here >> >> I picked JDK-8138732 to work on because it has a "starter" label and I >> believe I understand what to do. >> >> - I tried to update the copyright year to 2020 in every file. >> - I decided to change `@sin

Re: RFR: 8253322 : Update the specification in the newly added constructors

2020-09-23 Thread Phil Race
On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov wrote: > Looks like different people use a different style for the new constructors, > it will be good to unify them. > I have started from https://bugs.openjdk.java.net/browse/JDK-8252721 > See > https://bugs.openjdk.java.net/browse/JDK-8252908?

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package [v5]

2020-09-23 Thread Vladimir Kozlov
On Wed, 23 Sep 2020 18:41:06 GMT, Philippe Marschall wrote: >> Hello, newbie here >> >> I picked JDK-8138732 to work on because it has a "starter" label and I >> believe I understand what to do. >> >> - I tried to update the copyright year to 2020 in every file. >> - I decided to change `@sin

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package [v5]

2020-09-23 Thread Philippe Marschall
> Hello, newbie here > > I picked JDK-8138732 to work on because it has a "starter" label and I > believe I understand what to do. > > - I tried to update the copyright year to 2020 in every file. > - I decided to change `@since` from 9 to 16 since it is a new annotation name > in a new package

Re: RFR: 8253322 : Update the specification in the newly added constructors

2020-09-23 Thread Prasanta Sadhukhan
On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov wrote: > Looks like different people use a different style for the new constructors, > it will be good to unify them. > I have started from https://bugs.openjdk.java.net/browse/JDK-8252721 > See > https://bugs.openjdk.java.net/browse/JDK-8252908?

RFR: 8253322 : Update the specification added to some of some newly added constructors

2020-09-23 Thread Sergey Bylokhov
Looks like different people use a different style for the new constructors, it will be good to unify them. I have started from https://bugs.openjdk.java.net/browse/JDK-8252721 See https://bugs.openjdk.java.net/browse/JDK-8252908?focusedCommentId=14370006&page=com.atlassian.jira.plugin.system.issue