On Tue, 22 Sep 2020 08:43:04 GMT, Erik Gahlin wrote:
>> Marked as reviewed by kvn (Reviewer).
>
> Have you run the JFR tests in test/jdk/jdk/jfr?
@marschall Please do not force-push anything as it breaks the commit history in
the PR and renders previous
reviews/comments obsolete. There is no wa
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name
> in a new package
On Wed, 16 Sep 2020 17:29:52 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the fix to the issue wrt missing hashCode() javadoc, which was
> recently discussed in core-libs ml.
This pull request has now been integrated.
Changeset: bddb8225
Author:Naoto Sato
URL: https://git.openjdk
On Mon, 21 Sep 2020 20:17:36 GMT, Phil Race wrote:
> https://bugs.openjdk.java.net/browse/JDK-8252195
> is another one of the issues adding missing explicit no-args constructors in
> the desktop module.
>
> As well as being nested, these are all concrete, but protected, classes and
> so the co
On Wed, 16 Sep 2020 18:02:42 GMT, Naoto Sato wrote:
>> Hi,
>>
>> Please review the fix to the issue wrt missing hashCode() javadoc, which was
>> recently discussed in core-libs ml.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Tue, 22 Sep 2020 16:08:12 GMT, Phil Race wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8252195
>> is another one of the issues adding missing explicit no-args constructors in
>> the desktop module.
>>
>> As well as being nested, these are all concrete, but protected, classes and
>> so
On Fri, 18 Sep 2020 23:47:56 GMT, Yumin Qi wrote:
> With more CDS related code added to VM, it is time to move CDS code to a
> separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4
This pull request has now been integrated.
Changeset: c1df13b8
Author:Yumin Qi
U
> https://bugs.openjdk.java.net/browse/JDK-8252195
> is another one of the issues adding missing explicit no-args constructors in
> the desktop module.
>
> As well as being nested, these are all concrete, but protected, classes and
> so the constructors
> are protected.
>
> CSR here https://bug
On Mon, 21 Sep 2020 20:17:36 GMT, Phil Race wrote:
> https://bugs.openjdk.java.net/browse/JDK-8252195
> is another one of the issues adding missing explicit no-args constructors in
> the desktop module.
>
> As well as being nested, these are all concrete, but protected, classes and
> so the co
On Mon, 21 Sep 2020 22:24:15 GMT, Yumin Qi wrote:
>> With more CDS related code added to VM, it is time to move CDS code to a
>> separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional
> comm
On Sat, 12 Sep 2020 00:19:00 GMT, Vladimir Kozlov wrote:
>> Philippe Marschall has refreshed the contents of this pull request, and
>> previous commits have been removed. The
>> incremental views will show differences compared to the previous content of
>> the PR. The pull request contains one
11 matches
Mail list logo
