Re: [15] RFR: 8245241: Incorrect locale provider preference is not logged

2020-05-21 Thread Daniel Fuchs
Hi Naoto, On 21/05/2020 20:00, naoto.s...@oracle.com wrote: In fact, this piece of code should not happen as those adapter classes are all JDK provided classes. I replaced the above code with ServiceConfigurationError, like other similar locations (e.g, HostLocaleProviderAdapter - line 64-65).

Re: [15] RFR: 8245241: Incorrect locale provider preference is not logged

2020-05-21 Thread naoto . sato
Hi Daniel, Thank you for your review! On 5/21/20 3:42 AM, Daniel Fuchs wrote: Hi Naoto, Logging uses: ZonedDateTime zdt = ZonedDateTime.ofInstant(     record.getInstant(), ZoneId.systemDefault()); and then String.format("%1$tb %1$td, %1$tY %1$tl:%1$tM:%1$tS %1$Tp %2$s%n%4$s: %

Re: [15] RFR: 8245241: Incorrect locale provider preference is not logged

2020-05-21 Thread Daniel Fuchs
Hi Naoto, Logging uses: ZonedDateTime zdt = ZonedDateTime.ofInstant( record.getInstant(), ZoneId.systemDefault()); and then String.format("%1$tb %1$td, %1$tY %1$tl:%1$tM:%1$tS %1$Tp %2$s%n%4$s: %5$s%6$s%n", ...) to format the date. If the locale provider can't be loaded, is