Re: RFR: 8235834 IBM-943 charset encoder needs updating

2020-02-21 Thread naoto . sato
Two subtle comments to the new webrev: - I'd add "private" to those static finals. - "cs.name()" in the exception messages can be replaced with "csName". Otherwise it looks good. If you agree with the above, no further review is needed. Also, if you need a sponsor, I can sponsor your changeset.

Re: RFR: 8235834 IBM-943 charset encoder needs updating

2020-02-21 Thread Ichiroh Takiguchi
Hello Naoto. I appreciate your suggestions. I applied your suggestions into new patch. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8235834 Change: https://cr.openjdk.java.net/~itakiguchi/8235834/webrev.01/ Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2020-