That sounds good. JIRA makes sense.
Best,
Joe
On 11/6/19 6:34 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Thanks for the review! I tried to draft some comments, but thinking of
it, it could be confusing to leave a comment for a removed (wrong)
code. So instead of leaving code comments, I modifi
Hi Joe,
Thanks for the review! I tried to draft some comments, but thinking of
it, it could be confusing to leave a comment for a removed (wrong) code.
So instead of leaving code comments, I modified the JIRA issue
mentioning it, so that maintainers later could find out the rationale.
Naoto
Looks good to me. It might be good to leave a note to the method about
the change (e.g. why it no longer substitutes).
-Joe
On 11/6/19 1:45 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8233579
The proposed change
Hi Brent,
Thank you for the review! Please see my comments below.
On 11/6/19 3:27 PM, Brent Christian wrote:
Hi, Naoto
Looks pretty good. I have a few comments:
--
src/java.base/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
572 map = new
Hi, Naoto
Looks pretty good. I have a few comments:
--
src/java.base/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
572 map = new HashMap<>();
FWIW, I believe the HashMap could be pre-sized using 'names.length'.
--
src/java.base/macosx/native
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8233579
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8233579/webrev.00/
The problem was in the CLDR converter where it substitutes the context
dependent style names with sta
