[14]RFR of JDK-8227289:Enable assertions for some shell to java conversion tests after JDK-8218960

2019-07-09 Thread Ying Zhou
Hello, Please review this patch for updating below tests by adding -ea/esa to launcher parameters. - /test/jdk/java/util/Calendar/SupplementalJapaneseEraTestRun.java - /test/jdk/java/util/TimeZone/TimeZoneDatePermissionCheckRun.java - /test/jdk/java/util/TimeZone/Bug8066652Run.java - /test/jd

Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

2019-07-09 Thread Roger Riggs
Hi Thejasvi, Looks good, thanks for the updates Roger On 7/9/19 3:50 AM, Thejasvi Voniadka wrote: Hi Roger, Please find the updated webrev: http://cr.openjdk.java.net/~vagarwal/8154520/webrev.4/ I have updated both lines 3924 and 3874 of .../java/time/format/DateTimeFormatterBuilder.java.

Re: RFR: 8224560: (tz) Upgrade time-zone data to tzdata2019a and 8225580: tzdata2018i integration causes test failures on jdk-13

2019-07-09 Thread naoto . sato
Looks good, Ramanand. Naoto On 7/9/19 5:09 AM, Ramanand Patil wrote: Hi Naoto, Thank you for the review. Revised webrev: http://cr.openjdk.java.net/~rpatil/8224560/webrev.02/ I plan to push the changes tomorrow, if there are no further comments. Regards, Ramanand. -Original Message--

Re: RFR: 8224560: (tz) Upgrade time-zone data to tzdata2019a and 8225580: tzdata2018i integration causes test failures on jdk-13

2019-07-09 Thread Ramanand Patil
Hi Naoto, Thank you for the review. Revised webrev: http://cr.openjdk.java.net/~rpatil/8224560/webrev.02/ I plan to push the changes tomorrow, if there are no further comments. Regards, Ramanand. > -Original Message- > From: Naoto Sato > Sent: Monday, July 8, 2019 11:19 PM > To: Raman

Re: RFR: 8154520: java.time: appendLocalizedOffset() should return the localized "GMT" string

2019-07-09 Thread Thejasvi Voniadka
Hi Roger, Please find the updated webrev: http://cr.openjdk.java.net/~vagarwal/8154520/webrev.4/ I have updated both lines 3924 and 3874 of .../java/time/format/DateTimeFormatterBuilder.java. I have reduced the number of tests to just 3, and the number of locales to just 1 in java/time/forma