Re: RFR: X11 default visual support for IM status window on VNC

2019-01-29 Thread Sergey Bylokhov
Looks fine, if there are no other comments I'll push the fix this week. On 21/01/2019 20:08, Ichiroh Takiguchi wrote: Hello Sergey. Sorry, code conflict was there. I fixed code conflict and modified Copyright year. Could you review the fix again ? Bug:    https://bugs.openjdk.java.net/browse

Re: [13] RFR: 8217609: New era placeholder not recognized by java.text.SimpleDateFormat

2019-01-29 Thread Nishit Jain
Hi Naoto, Look good to me. Regards, Nishit Jain On 26-01-2019 01:29, naoto.s...@oracle.com wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8217609 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8217609/webrev.00/