Re: Fw: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting

2018-12-11 Thread naoto . sato
Looks good to me. Naoto On 12/11/18 8:32 PM, Toshio 5 Nakamura wrote: Hello Naoto, Thank you for your review. The updated webrev: http://cr.openjdk.java.net/~tnakamura/8213183/webrev.02/ Thanks, Toshio Nakamura Naoto Sato wrote on 2018/12/12 06:27:46: > From: Naoto Sato > To: Toshio 5

Re: Fw: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting

2018-12-11 Thread Toshio 5 Nakamura
Hello Naoto, Thank you for your review. The updated webrev: http://cr.openjdk.java.net/~tnakamura/8213183/webrev.02/ Thanks, Toshio Nakamura Naoto Sato wrote on 2018/12/12 06:27:46: > From: Naoto Sato > To: Toshio 5 Nakamura , awt- > d...@openjdk.java.net, i18n-dev@openjdk.java.net > Date: 2

Re: Fw: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting

2018-12-11 Thread Naoto Sato
Hello, I would rather not create a new test directory ReconnectTest. Instead, moving the test under InputContext would just be fine. Other than that, looks good to me. Naoto On 12/4/18 6:45 PM, Toshio 5 Nakamura wrote: Hello, Can anyone support this proposal? I appreciate any suggestion or

Re: [12] RFR: 8215194: Initial size of UnicodeBlock map is incorrect

2018-12-11 Thread Rachna Goel
Hi Naoto, Thanks for fixing this. Your fix looks good to me. Thanks, Rachna On 12/11/18 8:21 PM, Naoto Sato wrote: Hi, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8215194 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/821519

[12] RFR: 8215194: Initial size of UnicodeBlock map is incorrect

2018-12-11 Thread Naoto Sato
Hi, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8215194 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8215194/webrev.00/ This one line fix is for the correctness of the initial map size of Character.UnicodeBlock. Naoto