Re: [12]RFR of JDK-8210409:Refactor java.util.TimeZone:i18n shell tests to plain java tests

2018-10-29 Thread Naoto Sato
Looks good. Naoto On 10/28/18 11:55 PM, Ying Zhou wrote: Hello, test/jdk/java/util/TimeZone/OldIDMappingTest.sh test/jdk/java/util/TimeZone/Bug8066652.sh test/jdk/java/util/TimeZone/TimeZoneDatePermissionCheck.sh Please review this patch to refactor above shell script tests to java. Bug: htt

Re: RFR: 8213085: (tz) Upgrade time-zone data to tzdata2018g

2018-10-29 Thread Naoto Sato
Looks good. Thanks for catching up with it quickly. Naoto On 10/29/18 8:19 AM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA integration (tzdata2018g) into JDK12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213085 Webrev: http://cr.openjdk.java.net/~rpatil/8213085/webrev.00/

Re: RFR: 8213085: (tz) Upgrade time-zone data to tzdata2018g

2018-10-29 Thread Martin Buchholz
LGTM. On Mon, Oct 29, 2018 at 8:19 AM, Ramanand Patil wrote: > Hi all, > Please review the latest TZDATA integration (tzdata2018g) into JDK12. > Bug: https://bugs.openjdk.java.net/browse/JDK-8213085 > Webrev: http://cr.openjdk.java.net/~rpatil/8213085/webrev.00/ > > All the TimeZone related test

RFR: 8213085: (tz) Upgrade time-zone data to tzdata2018g

2018-10-29 Thread Ramanand Patil
Hi all, Please review the latest TZDATA integration (tzdata2018g) into JDK12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213085 Webrev: http://cr.openjdk.java.net/~rpatil/8213085/webrev.00/ All the TimeZone related tests are passed after integration. Regards, Ramanand.

Re: RFR: 8213016: (tz) Upgrade time-zone data to tzdata2018f

2018-10-29 Thread Ramanand Patil
Thank you Martin and Naoto for your reviews. Unfortunately, I have to discard this review and start a new review for tzdata2018g, since 2018g is already released now. Regards, Ramanand. > -Original Message- > From: Naoto Sato > Sent: Saturday, October 27, 2018 1:41 AM > To: Martin Buchho