Re: [12] RFR: 8212941: Loosen the range of JapaneseEra

2018-10-26 Thread naoto . sato
Hi Joe, On 10/26/18 3:00 PM, joe darcy wrote: Hi Naoto, I'd like to see a bit some discussion up front about the expected evolution of this class. For example, "once an era is defined, subsequent versions of the API will add a constant for it. etc. Eras are expected to have consecutive int

Re: [12] RFR: 8212941: Loosen the range of JapaneseEra

2018-10-26 Thread joe darcy
Hi Naoto, I'd like to see a bit some discussion up front about the expected evolution of this class. For example, "once an era is defined, subsequent versions of the API will add a constant for it. etc. Eras are expected to have consecutive integers associated with them, etc. " Once a form

[12] RFR: 8212941: Loosen the range of JapaneseEra

2018-10-26 Thread naoto . sato
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8212941 The proposed fix and CSR (not approved yet) are located at: http://cr.openjdk.java.net/~naoto/8212941/webrev.02/ https://bugs.openjdk.java.net/browse/JDK-8212942 This change is intended to lo

Re: RFR: 8213016: (tz) Upgrade time-zone data to tzdata2018f

2018-10-26 Thread naoto . sato
+1 Naoto On 10/26/18 12:38 PM, Martin Buchholz wrote: Looks good to me. On Fri, Oct 26, 2018 at 11:30 AM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA integration (tzdata2018f) into JDK12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213016 Webrev: http://cr.openjdk.java.

Re: RFR: 8213016: (tz) Upgrade time-zone data to tzdata2018f

2018-10-26 Thread Martin Buchholz
Looks good to me. On Fri, Oct 26, 2018 at 11:30 AM, Ramanand Patil wrote: > Hi all, > Please review the latest TZDATA integration (tzdata2018f) into JDK12. > Bug: https://bugs.openjdk.java.net/browse/JDK-8213016 > Webrev: http://cr.openjdk.java.net/~rpatil/8213016/webrev.00/ > > All the TimeZone

RFR: 8213016: (tz) Upgrade time-zone data to tzdata2018f

2018-10-26 Thread Ramanand Patil
Hi all, Please review the latest TZDATA integration (tzdata2018f) into JDK12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213016 Webrev: http://cr.openjdk.java.net/~rpatil/8213016/webrev.00/ All the TimeZone related tests are passed after integration. Note: The used tzdata files are from the r