Re: [12]: RFR: 8209167: Use CLDR's time zone mappings for Windows

2018-09-12 Thread Erik Joelsson
Looks good. /Erik On 2018-09-12 10:33, naoto.s...@oracle.com wrote: Hi Magnus, Erik, Thank you for your comments. I updated the webrev according to your suggestions: http://cr.openjdk.java.net/~naoto/8209167/webrev.02/ As to the duplicated "common" in the dependency, yes that's a separate

Re: [12]: RFR: 8209167: Use CLDR's time zone mappings for Windows

2018-09-12 Thread naoto . sato
Hi Magnus, Erik, Thank you for your comments. I updated the webrev according to your suggestions: http://cr.openjdk.java.net/~naoto/8209167/webrev.02/ As to the duplicated "common" in the dependency, yes that's a separate issue. Since it's obvious, I included the fix with this changeset (it

Re: [12]: RFR: Use CLDR's time zone mappings for Windows

2018-09-12 Thread Erik Joelsson
On 2018-09-12 03:19, Magnus Ihse Bursie wrote: On 2018-09-10 23:34, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209167 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8209167/webrev.01/ Some comm

Re: [12]: RFR: Use CLDR's time zone mappings for Windows

2018-09-12 Thread Magnus Ihse Bursie
On 2018-09-12 12:19, Magnus Ihse Bursie wrote: On 2018-09-10 23:34, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209167 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8209167/webrev.01/ Oh, and

Re: [12]: RFR: Use CLDR's time zone mappings for Windows

2018-09-12 Thread Magnus Ihse Bursie
On 2018-09-10 23:34, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209167 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8209167/webrev.01/ Some comments: In make/copy/Copy-java.base.gmk: +ifneq (