Re: [12] RFR 8021322: [Fmt-Ch] Implementation of ChoiceFormat math methods should delegate to java.lang.Math methods

2018-07-26 Thread Joseph D. Darcy
Looks fine; cheers, -Joe On 7/26/2018 9:26 AM, Naoto Sato wrote: Looks good. Naoto On 7/26/18 1:34 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8021322. CSR for the spec changes has been approved. Bug: https://bugs.openjdk.java.net/browse/JDK-8021322 Webrev: http://cr.openjdk

Re: [12] RFR 8021322: [Fmt-Ch] Implementation of ChoiceFormat math methods should delegate to java.lang.Math methods

2018-07-26 Thread Naoto Sato
Looks good. Naoto On 7/26/18 1:34 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8021322. CSR for the spec changes has been approved. Bug: https://bugs.openjdk.java.net/browse/JDK-8021322 Webrev: http://cr.openjdk.java.net/~nishjain/8021322/webrev.01/ CSR: https://bugs.openjdk.jav

[12] RFR 8021322: [Fmt-Ch] Implementation of ChoiceFormat math methods should delegate to java.lang.Math methods

2018-07-26 Thread Nishit Jain
Hi, Please review the fix for JDK-8021322. CSR for the spec changes has been approved. Bug: https://bugs.openjdk.java.net/browse/JDK-8021322 Webrev: http://cr.openjdk.java.net/~nishjain/8021322/webrev.01/ CSR: https://bugs.openjdk.java.net/browse/JDK-8208071 Fix: Changed the ChoiceFormat's ne