Re: [11]RFR 8194152: sun/security/tools/jarsigner/AltProvider.java failed on de-DE locale

Hi Dora, You could move those two lines that sets the locale to en-US before the for-loop, so that if "args" contains -J-Duser.language/country then it can override the default en-US. The JIRA issue needs noreg-self label. Naoto On 6/22/18 1:26 AM, Dora Zhou wrote: Hello, Please help revi

Re: RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

+1 Naoto On 6/22/18 9:55 AM, mandy chung wrote: webrev.01 looks better and it wraps long lines. Mandy On 6/22/18 9:34 AM, Rachna Goel wrote: Hi Mandy, Thanks for the review. Unicode 10.0.0 and ICU 60.2 were integrated with : https://bugs.openjdk.java.net/browse/JDK-8191410 and CLDR 33 w

Re: RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

webrev.01 looks better and it wraps long lines. Mandy On 6/22/18 9:34 AM, Rachna Goel wrote: Hi Mandy, Thanks for the review. Unicode 10.0.0 and ICU 60.2 were integrated with : https://bugs.openjdk.java.net/browse/JDK-8191410 and CLDR 33 was: https://bugs.openjdk.java.net/browse/JDK-820253

Re: RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

Hi Mandy, Thanks for the review. Unicode 10.0.0 and ICU 60.2 were integrated with : https://bugs.openjdk.java.net/browse/JDK-8191410 and CLDR 33 was: https://bugs.openjdk.java.net/browse/JDK-8202537 Linked mentioned issues with this one. Thanks, Rachna On 6/22/18 9:57 PM, mandy chung wro

Re: RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

Hi, Kindly ignore patch mentioned in previous mail. patch for review is : http://cr.openjdk.java.net/~rgoel/JDK-8205158/webrev.01/ Thanks, Rachna On 6/22/18 7:24 PM, Rachna Goel wrote: Hi, Kindly review fix to update legal files for Unicode, CLDR and ICU. Issue: https://bugs.openjdk.jav

Re: RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

On 6/22/18 6:54 AM, Rachna Goel wrote: Hi, Kindly review fix to update legal files for Unicode, CLDR and ICU. Issue: https://bugs.openjdk.java.net/browse/JDK-8205158 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8205158/webrev.02/ Looks okay. What are the issues that upgrades these librar

RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

Hi, Kindly review fix to update legal files for Unicode, CLDR and ICU. Issue: https://bugs.openjdk.java.net/browse/JDK-8205158 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8205158/webrev.02/ -- Thanks, Rachna

Re: [11] Review Request: 8202696 glyphs in textfield only shown when thai baht-character is added

Looks good. Naoto On 6/21/18 10:21 AM, Naoto Sato wrote: Hi Dipak, Please use Locale.toLowerCase(Locale.ROOT) instead of no-arg toLowerCase(), as it could fail in tr locale (line 60 in the test case). Naoto On 6/18/18 12:29 AM, Dipak Kumar wrote: Hi Phil, I am able to make the test autom

Proposal: Reverse attribute remains incorrectly with Input Method

Hello, IBM would like to contribute a patch to OpenJDK project. We'd like to propose a fix of Input Method relating problem. Can we have a sponsor of the patch? Problem: When Input Method's preedit text and text selection were mixed, the reverse attribute of selection remained unexpectedly. R

[11]RFR 8194152: sun/security/tools/jarsigner/AltProvider.java failed on de-DE locale

Hello, Please help review the fix for JDK-8194152. Thank you. The test compares output with expected error messages in English, set locale to en-US so that the output are not translated into other languages. Bug: https://bugs.openjdk.java.net/browse/JDK-8194152 Webrev: http://cr.openjdk.java.