Looks good.
Naoto
On 6/20/18 3:32 AM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8204938
Bug: https://bugs.openjdk.java.net/browse/JDK-8204938
Webrev: http://cr.openjdk.java.net/~nishjain/8204938/webrev.02/
Fix: Added a test case to cross check the LSR data generated for the JDK
A
+1 (approved).
-phil.
On 06/18/2018 12:29 AM, Dipak Kumar wrote:
Hi Phil,
I am able to make the test automated after incorporating your suggestion to
limit the test case to logical fonts.
I observed that "canDisplayUpTo()" which internally uses "canDisplay()" does
return expected values for
My question has not been answered. I don't think this is ready to go in.
-phil.
On 6/20/18, 4:23 AM, Ichiroh Takiguchi wrote:
Hello.
New fixed code is in:
http://cr.openjdk.java.net/~aleonard/defvis/webrev.02/
Could you check fixed files again ?
I only updated following part between webrev.0
Hello.
New fixed code is in:
http://cr.openjdk.java.net/~aleonard/defvis/webrev.02/
Could you check fixed files again ?
I only updated following part between webrev.01 and webrev.02
==
diff -r 70a582d110a1 -r 6f04164a9d62
src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c
--- a
Hi,
Please review the fix for JDK-8204938
Bug: https://bugs.openjdk.java.net/browse/JDK-8204938
Webrev: http://cr.openjdk.java.net/~nishjain/8204938/webrev.02/
Fix: Added a test case to cross check the LSR data generated for the JDK
APIs. So, for each lsr data update, the test case need not be