Re: RFR[JDK10]: 8195837: (tz) Support tzdata2018c

2018-01-29 Thread Naoto Sato
Looks good to me. Naoto On 1/29/18 12:49 AM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA integration (tzdata2018c) into JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8195837 Webrev: http://cr.openjdk.java.net/~rpatil/8195837/webrev.00/ All the TimeZone related tests ar

Re: RFR[JDK10]: 8195837: (tz) Support tzdata2018c

2018-01-29 Thread Martin Buchholz
Google has been successfully running jdk8 and jdk9 with 2018c. On Mon, Jan 29, 2018 at 12:49 AM, Ramanand Patil wrote: > Hi all, > Please review the latest TZDATA integration (tzdata2018c) into JDK10. > Bug: https://bugs.openjdk.java.net/browse/JDK-8195837 > Webrev: http://cr.openjdk.java.net/~r

Re: RFR[JDK10]: 8195837: (tz) Support tzdata2018c

2018-01-29 Thread Andrew Hughes
On 29 January 2018 at 14:42, Seán Coffey wrote: > The changes look fine to me Ramanand. The europe file contains some > interesting comments about the rolled back changes that have been made for > 2018c. A plan on how to resolve these pending changes can be followed up via > JDK-8195595 > Yes...

Re: RFR[JDK10]: 8195837: (tz) Support tzdata2018c

2018-01-29 Thread Seán Coffey
The changes look fine to me Ramanand. The europe file contains some interesting comments about the rolled back changes that have been made for 2018c. A plan on how to resolve these pending changes can be followed up via JDK-8195595 Regards, Sean. On 29/01/18 08:49, Ramanand Patil wrote: Hi a

RFR[JDK10]: 8195837: (tz) Support tzdata2018c

2018-01-29 Thread Ramanand Patil
Hi all, Please review the latest TZDATA integration (tzdata2018c) into JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-8195837 Webrev: http://cr.openjdk.java.net/~rpatil/8195837/webrev.00/ All the TimeZone related tests are passed after integration. Regards, Ramanand.