Looks good to me.
Naoto
On 12/18/17 2:13 PM, mandy chung wrote:
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8193767/
The above includes the webrev, specdiff and javadoc for this update to
ResourceBundle, ResourceBundleProvider, and
AbstractResourceBundleProvider to improve the documenta
Hi Joe,
Thanks for the comments.
I have updated the CSR to have @implSpec in place of @implNote.
https://bugs.openjdk.java.net/browse/JDK-8191414
Regarding "An array with either 12 or 13 elements will be returned
depending on whether or {@link Calendar.UNDECIMBER} is supported." , I
would
Hello Joe,
Thanks for the review.
Reason I added @implNote is that it's the case for the default
implementation. Not added as a part of spec, as some implementation can
just return 12 element array for same methods through the
"java.text.spi.DateFormatSymbolsProvider" SPI.
Thanks,
Rachna
O
Hi Rachna,
On 12/19/2017 1:13 AM, Rachna Goel wrote:
Hello Joe,
Thanks for the review.
Reason I added @implNote is that it's the case for the default
implementation. Not added as a part of spec, as some implementation
can just return 12 element array for same methods through the
"java.text
Hello Rachna,
On 12/18/2017 10:35 PM, Rachna Goel wrote:
Hi,
Kindly review API Doc fix for java.text.DateFormatSymbols.
JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8146656
Webrev: http://cr.openjdk.java.net/~rgoel/8146656/webrev/
CSR: https://bugs.openjdk.java.net/browse/JDK-819141
