I revised the proposed changes, including java.time changes suggested by
Stephen (CSR is still in progress):
https://bugs.openjdk.java.net/browse/JDK-8191349
The entire webrev is located at:
http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.05/
And the diff webrev from
Looks good. As long as sampling the test data is meaningful, I think
it's OK.
Naoto
On 11/22/17 12:13 AM, Nishit Jain wrote:
Thanks Naoto,
> One nit in the test. At line 71, probably the original intention of
"str" is to list the accept languages in alphabetic order. Would you
change it?
Y
Thanks Naoto,
> One nit in the test. At line 71, probably the original intention of
"str" is to list the accept languages in alphabetic order. Would you
change it?
Yes, it is sorted according to weight then alphabetically. Updated the
test case.
http://cr.openjdk.java.net/~nishjain/8191404/w
