Re: JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c

2017-11-07 Thread Ramanand Patil
Thank you Martin for your review.   For the java file updates, currently I don’t use any script but just simple “find and replace” whenever possible and rest is manual. I run all the TZ related tests locally on Ubuntu and use JPRT for all other platforms.     Regards, Ramanand.   From: Ma

Re: JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c

2017-11-07 Thread Martin Buchholz
Looks good to me too. I've always wondered about how the corresponding java source files are maintained. Is it all manual or do y'all have some magic script to help keep IANA data and java data aligned? Do we need more testing that mistakes don't creep in? On Tue, Nov 7, 2017 at 3:41 AM, Ramana

Re: JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c

2017-11-07 Thread Naoto Sato
Looks good. Naoto On 11/7/17 3:41 AM, Ramanand Patil wrote: Hi Naoto, Thank you for pointing that. I have modified both the affected files(ZoneName.java from src and test). Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.01/ Regards, Ramanand. -Ori

Re: RFR: JDK-8190816 : PropertiesTest.sh fails to make $WRITABLEJDK writable

2017-11-07 Thread Naoto Sato
Looks good. Thanks for fixing this obvious mistake. Naoto On 11/6/17 7:38 PM, Martin Buchholz wrote: http://cr.openjdk.java.net/~martin/webrevs/openjdk10/Currency-PropertiesTest/

Re: JDK10 RFR of JDK-8190258: (tz) Support tzdata2017c and 8190259: test tck.java.time.zone.TCKZoneRules is broken by tzdata2017c

2017-11-07 Thread Ramanand Patil
Hi Naoto, Thank you for pointing that. I have modified both the affected files(ZoneName.java from src and test). Here is the updated Webrev: http://cr.openjdk.java.net/~rpatil/8190258+8190259/webrev.01/ Regards, Ramanand. > -Original Message- > From: Naoto Sato > Sent: Tuesday, November

Re: RFR: JDK-8190816 : PropertiesTest.sh fails to make $WRITABLEJDK writable

2017-11-07 Thread Rachna Goel
Hi Martin, I am not a reviewer though, your fix looks good to me. Thanks, Rachna On 07/11/17 9:08 AM, Martin Buchholz wrote: http://cr.openjdk.java.net/~martin/webrevs/openjdk10/Currency-PropertiesTest/ -- T