Re: [10] RFR JDK-8186713: Document default rounding mode in NumberFormat

2017-08-24 Thread Brian Burkhalter
A few minor comments: L178-195: Is a list necessary here? L186: I don’t think “Rounding: " is necessary. L187: s/the numbers/numbers/ L188: s/uses/uses the/ L191: s/its/the/ Thanks, Brian On Aug 24, 2017, at 12:06 AM, Nishit Jain wrote: > Webrev:http://cr.openjdk.java.net/~nishjain/818671

Re: [10] RFR JDK-8186713: Document default rounding mode in NumberFormat

2017-08-24 Thread Naoto Sato
Looks good. Naoto On 8/24/17 12:06 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8186713 Bug: https://bugs.openjdk.java.net/browse/JDK-8186713 Webrev: http://cr.openjdk.java.net/~nishjain/8186713/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8185777 Fix: Updated the spe

[10] RFR JDK-8186713: Document default rounding mode in NumberFormat

2017-08-24 Thread Nishit Jain
Hi, Please review the fix for JDK-8186713 Bug: https://bugs.openjdk.java.net/browse/JDK-8186713 Webrev: http://cr.openjdk.java.net/~nishjain/8186713/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8185777 Fix: Updated the specification of NumberFormat about the default rounding mode u