Re: [10] RFR: 8160199: Language's script should be reflected in user.script on Mac OS X

2017-06-28 Thread Naoto Sato
Thanks, Brent! Here is the updated webrev: http://cr.openjdk.java.net/~naoto/8160199/webrev.04/ And my comments embedded below: On 6/28/17 2:16 PM, Brent Christian wrote: Hi, Naoto This looks quite good. I will test a bit with some of the trickier locales. BTW, the script will now also be

Re: [10] RFR: 8160199: Language's script should be reflected in user.script on Mac OS X

2017-06-28 Thread Brent Christian
Hi, Naoto This looks quite good. I will test a bit with some of the trickier locales. BTW, the script will now also be reflected in Locale.getScript() and Locale.getDisplayScript(). Just a few comments: --- src/java.base/macosx/native/libjava/java_props_macosx.h Update copyright year ---

[10] RFR: 8160199: Language's script should be reflected in user.script on Mac OS X

2017-06-28 Thread Naoto Sato
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8160199 The fix is located at: http://cr.openjdk.java.net/~naoto/8160199/webrev.03/ The gist of the issue was that the script code has not been properly treated in macOS specific code. Since it shar