Re: [10] RFR: 8176160, 8176847, 8176853

2017-05-31 Thread Naoto Sato
Thanks, Martin. Updated the webrev for each: http://cr.openjdk.java.net/~naoto/8176160/webrev.01/ http://cr.openjdk.java.net/~naoto/8176847/webrev.01/ Naoto On 5/31/17 1:00 PM, Martin Buchholz wrote: Thanks - looks good. --- +private final static List cals = +List.of("gregorian",

Re: [10] RFR: 8176160, 8176847, 8176853

2017-05-31 Thread Martin Buchholz
Thanks - looks good. --- +private final static List cals = +List.of("gregorian", "japanese", "julian"); If you inline this into main, your beautiful stream pipeline will be even more beautiful! --- +import static java.util.Calendar.Builder; My colleagues would frown upon static im

[10] RFR: 8176160, 8176847, 8176853

2017-05-31 Thread Naoto Sato
Hi Martin, These are the issues you filed with proposed fixes. I supplemented the tests to them. Can you please review these changes: https://bugs.openjdk.java.net/browse/JDK-8176160 http://cr.openjdk.java.net/~naoto/8176160/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8176847 http://c