Re: Review Request JDK-8170772: ResourceBundle improper caching causes tools/javadoc tests intermittently

2016-12-09 Thread Daniel Fuchs
Hi Mandy, It will be good to have Naoto's opinion on this. But what you propose makes sense to me. best regards, -- daniel On 09/12/16 16:49, Mandy Chung wrote: Naoto, Can you review this ResourceBundle caching fix? The caller module may be different than the specified module to ResourceBun

Re: CFV: New Internationalization Group Lead: Naoto Sato

2016-12-09 Thread Steven R. Loomis
Vote: yes

Re: Review Request JDK-8170772: ResourceBundle improper caching causes tools/javadoc tests intermittently

2016-12-09 Thread Naoto Sato
Hi Mandy, The fix looks fine to me. Naoto On 12/9/16 10:05 AM, Daniel Fuchs wrote: Hi Mandy, It will be good to have Naoto's opinion on this. But what you propose makes sense to me. best regards, -- daniel On 09/12/16 16:49, Mandy Chung wrote: Naoto, Can you review this ResourceBundle ca

Re: RFR: 8039273: Font related files should not be modified in ${java.home}/lib

2016-12-09 Thread Naoto Sato
Hi Phil, In FontConfiguration.java, line 193-195 can be inserted just after line 191, as fontConfigFile is guaranteed to be non-null if userConfigFile is non null. Otherwise it looks good to me. Naoto On 12/8/16 12:01 PM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-803927

Review Request JDK-8170772: ResourceBundle improper caching causes tools/javadoc tests intermittently

2016-12-09 Thread Mandy Chung
Naoto, Can you review this ResourceBundle caching fix? The caller module may be different than the specified module to ResourceBundle.getBundle(String, Module) method and it should also part of the cache key. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8170772/webrev.00/ The new test shows