Re: Request for Review : JDK-8071929 -Locale.getISOCountries() has inconsistent behaviour for "AN", "BU" and "CS" country codes.

2016-12-05 Thread Rachna Goel
Hi Naoto, Thanks for suggestions. updated patch is at : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.04/ Thanks, Rachna On 06/12/16 4:47 AM, Naoto Sato wrote: Additional nit comments: Locale.java - Extra blank lines at line 628, 639. - The method name "getISOCountriesImpl" inside

Re: Request for Review : JDK-8071929 -Locale.getISOCountries() has inconsistent behaviour for "AN", "BU" and "CS" country codes.

2016-12-05 Thread Naoto Sato
Additional nit comments: Locale.java - Extra blank lines at line 628, 639. - The method name "getISOCountriesImpl" inside IsoCountryCode is somewhat strange. How about just "createCountryCodeSet()"? Also, its comment does not describe the method correctly. It does not seem a "mapping functio