Thank you Martin.
Regards,
Ramanand.
From: Martin Buchholz [mailto:marti...@google.com]
Sent: Tuesday, November 29, 2016 12:59 AM
To: Ramanand Patil
Cc: i18n-dev@openjdk.java.net; core-libs-dev
Subject: Re: RFR: 8169191: (tz) Support tzdata2016j
Thanks as always for keeping the tzdata
Hi Masayoshi,
Sorry, that was an error from my side. Thank you for pointing that out and for
your review.
[Changed the BugID in Subject now].
Regards,
Ramanand.
-Original Message-
From: Masayoshi Okutsu
Sent: Wednesday, November 30, 2016 10:08 AM
To: Ramanand Patil
Cc: Martin Buchhol
Sorry, but I was confused with the wrong bug ID in Subject...
Looks good to me.
Masayoshi
On 11/29/2016 4:28 AM, Martin Buchholz wrote:
Thanks as always for keeping the tzdata pipeline moving!
Looks good to me.
On Mon, Nov 28, 2016 at 1:24 AM, Ramanand Patil
wrote:
Hi all,
Please review t
Hi Rachna,
It's still unclear for me how this addition will be useful for
applications. But here are my comments on the implementation.
src/java.base/share/classes/java/util/LocaleISOData.java:
- iso3166CodesMap has to use a ConcurrentHashMap.
- The following code should use AssertionError rat
I'm concerned that this is not the friendliest of new APIs. There is
little description of the meaning of the ISO-3166 parts - what is
being added is directly exposing the underlying data rather than
providing any kind of abstraction.
There is also an inconsistency between "ISO" and "Iso" in the c
Looks good to me.
Naoto
On 11/29/16 1:07 AM, Rachna Goel wrote:
Hi,
Please review fix for JDK-8071929.
Bug : https://bugs.openjdk.java.net/browse/JDK-8071929
patch : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/
Fix is to remove obsolete country code "AN" and provide support for
Hi,
Please review fix for JDK-8071929.
Bug : https://bugs.openjdk.java.net/browse/JDK-8071929
patch : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/
Fix is to remove obsolete country code "AN" and provide support for
retrieving of ISO3166-1 alpha-2, ISO3166-1 alpha-3, ISO3166-3 cou
