Re: RFR: 8165804: Revisit the way of loading BreakIterator rules/dictionaries

2016-10-20 Thread Yuka Kamiya
+1 On 2016/10/21 1:24, Naoto Sato wrote: Looks good to me. Naoto On 10/20/16 1:33 AM, Masayoshi Okutsu wrote: Hi, Please review the changes for JDK-8165804 which is a follow-up of JDK-8076757. Some notes on the changes. - Removed INCLUDES := $(TEXT_PKG_LD) from make/gendata/GendataBreakIter

Re: RFR: 8165804: Revisit the way of loading BreakIterator rules/dictionaries

2016-10-20 Thread Naoto Sato
Looks good to me. Naoto On 10/20/16 1:33 AM, Masayoshi Okutsu wrote: Hi, Please review the changes for JDK-8165804 which is a follow-up of JDK-8076757. Some notes on the changes. - Removed INCLUDES := $(TEXT_PKG_LD) from make/gendata/GendataBreakIterator.gmk in order to avoid compiling non-Br

Re: RFR: JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider on locale de, de_DE, en_US.

2016-10-20 Thread Naoto Sato
Looks good, Rachna. Naoto On 10/20/16 1:27 AM, Rachna Goel wrote: Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.09/ Fix is to retrieve Narrow and Narrow_Standalone Month names and D

Re: RFR: JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider on locale de, de_DE, en_US.

2016-10-20 Thread Masayoshi Okutsu
Looks good to me. Masayoshi On 10/20/2016 5:27 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.09/ Fix is to retrieve Narrow and Narrow_Standalone Month names

RFR: 8165804: Revisit the way of loading BreakIterator rules/dictionaries

2016-10-20 Thread Masayoshi Okutsu
Hi, Please review the changes for JDK-8165804 which is a follow-up of JDK-8076757. Some notes on the changes. - Removed INCLUDES := $(TEXT_PKG_LD) from make/gendata/GendataBreakIterator.gmk in order to avoid compiling non-BreakIterator*.java for the build tool with boot JDK. - Added sun.ut

RFR: JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider on locale de, de_DE, en_US.

2016-10-20 Thread Rachna Goel
Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.09/ Fix is to retrieve Narrow and Narrow_Standalone Month names and Day names one by one, as they can be duplicate. Thanks, Rachna