Re: RFR:JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider.

2016-10-03 Thread Rachna Goel
Hi Masayoshi, Thanks for pointing out that. I have changed this test for java.time. Please have a look at updated webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.04/ Thanks, Rachna On 9/29/16 7:31 PM, Masayoshi Okutsu wrote: Hi Rachna, Sorry, but I've somehow overlooked this f

Re: RFR:JDK-8166993: Typo in java.util.Locale

2016-10-03 Thread Martin Buchholz
Thanks! On Mon, Oct 3, 2016 at 12:22 AM, Rachna Goel wrote: > Hi, > > Please review this simple documentation fix for JDK-8166993. > > Bug : https://bugs.openjdk.java.net/browse/JDK-8166993 > > webrev :http://cr.openjdk.java.net/~rgoel/JDK-8166993/webrev/ > > Thanks, > > Rachna > >

Re: RFR: 8166875: (tz) Support tzdata2016g

2016-10-03 Thread Martin Buchholz
Hi Ramanand, Pleased to meet you! I expected to see Yangon added to ZoneName, because of the existing reference to Rangoon java/time/test/java/time/format/ZoneName.java:179:"Asia/Rangoon", "Myanmar", "Asia/Rangoon", Is ZoneName.java trying to maintain a comprehensive list of zone names?

Re: Review Request for JDK-8165466: DecimalFormat percentage format can contain unexpected %

2016-10-03 Thread Yuka Kamiya
Hi Nisht, The fix looks good to me. Thanks, -- Yuka On 2016/10/03 19:56, Nishit Jain wrote: Hi, Please review the fix for JDK-8165466 Bug: https://bugs.openjdk.java.net/browse/JDK-8165466 Webrev: http://cr.openjdk.java.net/~nishjain/8165466/webrev.04/ Fix: FastPathData was not reinitializ

RFR: 8166875: (tz) Support tzdata2016g

2016-10-03 Thread Ramanand Patil
HI all, Please review the latest TZDATA integration (tzdata2016g) to JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8166875 Webrev: http://cr.openjdk.java.net/~rpatil/8166875/webrev.00/ All the TimeZone related tests are passed after integration. [BugID is updated for tests TimeZoneTest.java

Review Request for JDK-8165466: DecimalFormat percentage format can contain unexpected %

2016-10-03 Thread Nishit Jain
Hi, Please review the fix for JDK-8165466 Bug: https://bugs.openjdk.java.net/browse/JDK-8165466 Webrev: http://cr.openjdk.java.net/~nishjain/8165466/webrev.04/ Fix: FastPathData was not reinitialized for the subsequent format calls, hence FastPathData.fastPathContainer was using the old char

Re: RFR:JDK-8166993: Typo in java.util.Locale

2016-10-03 Thread Yuka Kamiya
Hi Rachna, The fix looks good to me. Thanks, -- Yuka On 2016/10/03 16:22, Rachna Goel wrote: Hi, Please review this simple documentation fix for JDK-8166993. Bug : https://bugs.openjdk.java.net/browse/JDK-8166993 webrev :http://cr.openjdk.java.net/~rgoel/JDK-8166993/webrev/ Thanks, Rachna

RFR:JDK-8166993: Typo in java.util.Locale

2016-10-03 Thread Rachna Goel
Hi, Please review this simple documentation fix for JDK-8166993. Bug : https://bugs.openjdk.java.net/browse/JDK-8166993 webrev :http://cr.openjdk.java.net/~rgoel/JDK-8166993/webrev/ Thanks, Rachna