Re: Review Request for JDK-8165984: ResourceBundle lookup fields not completely thread-safe

2016-09-16 Thread Masayoshi Okutsu
+1 Masayoshi On 9/17/2016 2:00 AM, Naoto Sato wrote: Looks good. BTW, I believe making it "final" means to make sure every threads are guaranteed to see the same value, not because it is not changed after the construction. Naoto On 9/16/16 2:09 AM, Nishit Jain wrote: Hi, Please review

Re: Review Request for JDK-8165984: ResourceBundle lookup fields not completely thread-safe

2016-09-16 Thread Naoto Sato
Looks good. BTW, I believe making it "final" means to make sure every threads are guaranteed to see the same value, not because it is not changed after the construction. Naoto On 9/16/16 2:09 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8165984 Bug: https://bugs.openjdk.java.n

Review Request for JDK-8165984: ResourceBundle lookup fields not completely thread-safe

2016-09-16 Thread Nishit Jain
Hi, Please review the fix for JDK-8165984 Bug: https://bugs.openjdk.java.net/browse/JDK-8165984 Webrev: http://cr.openjdk.java.net/~nishjain/8165984/webrev.01/ Fix: the private lookup variable is made final in PropertyResourceBundle as after initialization it is not changed anywhere. lookup va