Re: RFR: JDK-8163362-Reconsider reflection usage in java.awt.font.JavaAWTFontAccessImpl class

Looks good to me. Masayoshi On 8/22/2016 1:26 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8163362. https://bugs.openjdk.java.net/browse/JDK-8163362 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8163362/webrev.01/ This is a cleanup fix in which Reflection usage in JavaAWTFontAcces

Re: RFR: JDK-8135055.java.util.Date.after(java.sql.Timestamp ) does not return correct results

Looks good to me. Masayoshi On 8/22/2016 1:51 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8135055. Bug: https://bugs.openjdk.java.net/browse/JDK-8135055 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8135055/webrev.02/ Fix is to return getTime() if argument to getMillisOf() is a

Re: Review Request:JDK-8163350-LocaleProviderAdapter Preference list retrieved is wrong, when -Djava.locale.providers=COMPAT

Looks good to me. Masayoshi On 8/22/2016 1:10 PM, Rachna Goel wrote: Hi Masayoshi, Thanks for the review. please have a look at updated webrev http://cr.openjdk.java.net/~rgoel/jdk-8163350/webrev.04/ Thanks, Rachna On 8/16/16 1:16 PM, Masayoshi Okutsu wrote: Hi Rachna, The fix looks g

Re: RFR: JDK-7094818, JDK-8132861 and JDK-8134733

Looks good to me. Masayoshi On 8/22/2016 10:31 AM, Yuka Kamiya wrote: Hello, http://cr.openjdk.java.net/~peytoia/7094818.8132861.8134733/webrev.00/ Please review the fix for the following bugs: https://bugs.openjdk.java.net/browse/JDK-7094818 https://bugs.openjdk.java.net/browse/JDK-8132861

RFR: JDK-8135055.java.util.Date.after(java.sql.Timestamp ) does not return correct results

Hi, Please review fix for JDK-8135055. Bug: https://bugs.openjdk.java.net/browse/JDK-8135055 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8135055/webrev.02/ Fix is to return getTime() if argument to getMillisOf() is an instance of java.sql.TimeStamp. Thanks, Rachna

RFR: JDK-8163362-Reconsider reflection usage in java.awt.font.JavaAWTFontAccessImpl class

Hi, Please review fix for JDK-8163362. https://bugs.openjdk.java.net/browse/JDK-8163362 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8163362/webrev.01/ This is a cleanup fix in which Reflection usage in JavaAWTFontAccessImpl class was removed. Thanks, Rachna

Re: Review Request:JDK-8163350-LocaleProviderAdapter Preference list retrieved is wrong, when -Djava.locale.providers=COMPAT

Hi Masayoshi, Thanks for the review. please have a look at updated webrev http://cr.openjdk.java.net/~rgoel/jdk-8163350/webrev.04/ Thanks, Rachna On 8/16/16 1:16 PM, Masayoshi Okutsu wrote: Hi Rachna, The fix looks good to me. But the test should be changed. - It's unnecessary to statica

RFR: JDK-7094818, JDK-8132861 and JDK-8134733

Hello, http://cr.openjdk.java.net/~peytoia/7094818.8132861.8134733/webrev.00/ Please review the fix for the following bugs: https://bugs.openjdk.java.net/browse/JDK-7094818 https://bugs.openjdk.java.net/browse/JDK-8132861 https://bugs.openjdk.java.net/browse/JDK-8134733 Thanks, -- Yuka