Re: RFR: 8161203: ResourceBundle.getBundle performance regression

2016-07-21 Thread Masayoshi Okutsu
Hi Peter, Thank you for your suggestion. Actually CacheKey is used for storing information required to load resource bundles during a ResourceBundle.getBundle call. The current CacheKey usage may be too tricky and cause some maintenance problems. I will file a separate issue on that problem.

Re: RFR: 8161203: ResourceBundle.getBundle performance regression

2016-07-21 Thread Peter Levart
Hi Masayoshi, Previously the CacheKey::clone() method cleared a reference to 'providers' in the clone making the provides unreachable from the clone and making the clone unable to obtain providers. Now you also reset the 'providersChecked' flag which makes the clone be able to re-obtain the p

Re: RFR: 8161203: ResourceBundle.getBundle performance regression

2016-07-21 Thread Alan Bateman
On 21/07/2016 05:14, Masayoshi Okutsu wrote: Hi, Please review the fix for JDK-8161203. The fix is to lazily load ResourceBundleProviders. It's not necessary to load providers before cache look-up. Issue: https://bugs.openjdk.java.net/browse/JDK-8161203 Webrev: http://cr.openjdk.java.net/~