+1
> On 23/6/16 上午10:34, Naoto Sato wrote:
I see that you tested thoroughly :-)
Naoto
On 6/23/16 1:13 PM, Brent Christian wrote:
On 23/6/16 上午10:34, Naoto Sato wrote:
I reviewed webrev.04 thoroughly this time and comments below:
- Although the OSX API returns the cases as in the spec, BCP 4
On 23/6/16 上午10:34, Naoto Sato wrote:
I reviewed webrev.04 thoroughly this time and comments below:
- Although the OSX API returns the cases as in the spec, BCP 47 language
tags are case insensitive, so it would be better to check [a-z] in line
94/95 as well.
Done (and I've simplified the ass
On 6/23/16 8:24 AM, Naoto Sato wrote:
On 6/22/16 9:48 PM, Brent Christian wrote:
On 6/22/16 3:58 PM, Naoto Sato wrote:
2. I think mapping language/script combination to a typical locale is ok
to keep the compatibility (e.g., "sr-Latn" to "sr_CS", done by the JRS,
right?) In the meantime, I wou
I reviewed webrev.04 thoroughly this time and comments below:
- Although the OSX API returns the cases as in the spec, BCP 47 language
tags are case insensitive, so it would be better to check [a-z] in line
94/95 as well.
- Line 82: Does the API actually returns "zh-Hans_HK"? Underscore ('_'
Hi Rachna,
The test needs to be modified to ensure locales only for ROOT and en_US*
locales for java.base module. Currently it would pass if
getAvailableLocales() included English locales other than US ones, say
en_GB. I should have corrected it, but apparently I overlooked.
> if (nonEnglish
On 6/22/16 9:48 PM, Brent Christian wrote:
On 6/22/16 3:58 PM, Naoto Sato wrote:
Hi Brent,
1. It seems that the display language in the new code seems to have some
problems. I see (in es-419.txt):
---
locale[Default|Display|Format].getLanguage () is
user.language: it is
---
And in fact, displ
Hi,
Please review fix for JDK-8158504.
Bug : https://bugs.openjdk.java.net/browse/JDK-8158504
Webrev : http://cr.openjdk.java.net/~nishjain/rgoel/8158504/webrev.03/
Fix : Removed java.ext.dirs System property as it is no longer supported
in JDK9 and used "-limitmods java.base" to load only j
