On 6/22/16 3:58 PM, Naoto Sato wrote:
Hi Brent,
1. It seems that the display language in the new code seems to have some
problems. I see (in es-419.txt):
---
locale[Default|Display|Format].getLanguage () is
user.language: it is
---
And in fact, display strings are no longer in Spanish in the n
> On Jun 20, 2016, at 3:44 PM, Brent Christian
> wrote:
>
>
> Alex - thanks for your response. More below...
>
> On 6/13/16 4:51 PM, Alex Strange wrote:
>>> 2. In "setupMacOSXLocale" we simply drop the call to
>>> "JRSSetDefaultLocalization" as it appears to be a NOP. According to
>>> Apple,
Hi Brent,
1. It seems that the display language in the new code seems to have some
problems. I see (in es-419.txt):
---
locale[Default|Display|Format].getLanguage () is
user.language: it is
---
And in fact, display strings are no longer in Spanish in the new version
(as the language is "is")
On 22/06/16 15:10, Alex Strange wrote:
On Jun 20, 2016, at 3:44 PM, Brent Christian wrote:
I'd prefer something that can build on SDK 10.9 and 10.10, etc.
There might be a way to #ifdef it out (not sure), but it's not worth it.
I came to the same conclusion. :)
Thanks!
-Brent
On 6/21/16 3:27 PM, Naoto Sato wrote:
Actually, j.u.Locale class' "country" code is defined as ISO-3166
alpha-2 *or* UN M.49 numeric-3 area code, so if the OSX's underlying
setting is "es-419" for the preferred language, "user.country" should be
"419".
OK, thanks - looks like another latent loc
Looks good.
Masayoshi
On 6/22/2016 1:53 PM, Naoto Sato wrote:
Modified line 243-246 to avoid generating a new List instance with
Collectors.toList():
http://cr.openjdk.java.net/~naoto/8159781/webrev.03/
Naoto
On 6/21/16 1:51 PM, Naoto Sato wrote:
Thank you for the review, Masayoshi.
I do
> On Jun 21, 2016, at 9:53 PM, Naoto Sato wrote:
>
> Modified line 243-246 to avoid generating a new List instance with
> Collectors.toList():
>
> http://cr.openjdk.java.net/~naoto/8159781/webrev.03/
+1
Mandy