Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

2016-06-17 Thread Mandy Chung
> On Jun 17, 2016, at 3:29 PM, Naoto Sato wrote: > > Decided to fix this separately from the other include locales issues. Here is > the bug and the proposed fix: > > https://bugs.openjdk.java.net/browse/JDK-8159781 > http://cr.openjdk.java.net/~naoto/8159781/webrev.00/ The change looks okay.

[9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

2016-06-17 Thread Naoto Sato
Decided to fix this separately from the other include locales issues. Here is the bug and the proposed fix: https://bugs.openjdk.java.net/browse/JDK-8159781 http://cr.openjdk.java.net/~naoto/8159781/webrev.00/ The change is to explicitly specify "regex" path matching along with the pattern mod

Re: Review Request for JDK-8159420 : The LanguageRange.parse() method is throwing IllegalArgumentException in Turkish Locale

2016-06-17 Thread Naoto Sato
Looks good to me. Naoto On 17/06/2016 01:16, Nishit Jain wrote: Hi, Please review the fix for JDK-8159420 Bug: https://bugs.openjdk.java.net/browse/JDK-8159420 Webrev: http://cr.openjdk.java.net/~nishjain/8159420/webrev.04/ Fix: Changed the toLowerCase() method on language-ranges and languag

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

2016-06-17 Thread Naoto Sato
I will take care of that along with other include locales issues. Naoto On 17/06/2016 01:14, Masayoshi Okutsu wrote: I've been waiting for JDK-8159206 to be fixed. But this test still fails after the JDK-8159206 fix. I've filed JDK-8159781 for the failure and pushed this test fix with the follo

Re: Review Request for JDK-8159420 : The LanguageRange.parse() method is throwing IllegalArgumentException in Turkish Locale

2016-06-17 Thread Yuka Kamiya
+1 On 2016/06/17 17:40, Masayoshi Okutsu wrote: Looks good. Thanks, Masayoshi On 6/17/2016 5:16 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8159420 Bug: https://bugs.openjdk.java.net/browse/JDK-8159420 Webrev: http://cr.openjdk.java.net/~nishjain/8159420/webrev.04/ Fix: Change

Re: Review Request for JDK-8159420 : The LanguageRange.parse() method is throwing IllegalArgumentException in Turkish Locale

2016-06-17 Thread Masayoshi Okutsu
Looks good. Thanks, Masayoshi On 6/17/2016 5:16 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8159420 Bug: https://bugs.openjdk.java.net/browse/JDK-8159420 Webrev: http://cr.openjdk.java.net/~nishjain/8159420/webrev.04/ Fix: Changed the toLowerCase() method on language-ranges and

Review Request for JDK-8159420 : The LanguageRange.parse() method is throwing IllegalArgumentException in Turkish Locale

2016-06-17 Thread Nishit Jain
Hi, Please review the fix for JDK-8159420 Bug: https://bugs.openjdk.java.net/browse/JDK-8159420 Webrev: http://cr.openjdk.java.net/~nishjain/8159420/webrev.04/ Fix: Changed the toLowerCase() method on language-ranges and language-tags to toLowerCase(Locale.ROOT) because characters in language

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

2016-06-17 Thread Masayoshi Okutsu
I've been waiting for JDK-8159206 to be fixed. But this test still fails after the JDK-8159206 fix. I've filed JDK-8159781 for the failure and pushed this test fix with the following ProblemList.txt change: diff --git a/test/ProblemList.txt b/test/ProblemList.txt --- a/test/ProblemList.txt +++