Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-14 Thread Brent Christian
On 6/13/16 4:20 PM, Brent Christian wrote: On 13/06/2016 14:43, Naoto Sato wrote: Also, the array index "2" to assume the language length is 2 is not correct, as there are three letter language codes. So the code should literally look for "-" instead. Great, thanks. I will fix that. FYI, t

Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-14 Thread Gerard Ziemski
hi Brent, Thank you very much for tackling this. The code overall looks good (aside from the 3 code language sub tag case that we need to handle, as Naoto pointed out) Here are my 2 small comments: #1 63 CFRelease(languages); // was missing from original patch I think we can