Hi,
Please review this Mac-only fix:
http://cr.openjdk.java.net/~bchristi/7131356/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-7131356
Thanks go to Gerard Ziemski for the thorough investigation and detailed
write-up in the bug report.
The symptoms:
On those OS X machines where the de
Hi Again,
I also have a comment on the implementation of the hash table and it's
GC-ness. You keep the string pool under a SoftReference because it is
the biggest object so it makes most sense to clear it when heap becomes
full. Other arrays are kept strongly reachable, but you re-generate the
> On Jun 13, 2016, at 1:58 PM, Brent Christian
> wrote:
>
> Hi,
>
> Please review this Mac-only fix:
>
> http://cr.openjdk.java.net/~bchristi/7131356/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-7131356
>
> Thanks go to Gerard Ziemski for the thorough investigation and detailed
> w
Hi Sherman,
I don't currently have any idea how to squeeze the hashtable any more
further. It is already very compact in my opinion. But I noticed a data
race that could result in navigating the half-initialized data
structure. It is a classical unsafe publication bug. It has been present
bef
Hi, Naoto. Thank you for having a look.
On 13/06/2016 14:43, Naoto Sato wrote:
On 6/13/16 1:58 PM, Brent Christian wrote:
The original Apple code then calls into
"JRSCopyCanonicalLanguageForPrimaryLanguage" to map "language" into
"language_REGION" (ex. "en"-->"en_US", "fr"-->"fr_FR", etc.), t
+1
Thanks,
--
Yuka
On 2016/06/14 11:27, Masayoshi Okutsu wrote:
Looks good to me.
Masayoshi
On 6/13/2016 6:54 PM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8135061
Bug: https://bugs.openjdk.java.net/browse/JDK-8135061
Webrev: http://cr.openjdk.java.net/~nishjain/8135061/webrev.0
Looks good to me.
Masayoshi
On 6/13/2016 6:54 PM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8135061
Bug: https://bugs.openjdk.java.net/browse/JDK-8135061
Webrev: http://cr.openjdk.java.net/~nishjain/8135061/webrev.01/
Fix : Added a check on the lastIndexOf "-" before using substri
On 13/06/2016 16:20, Brent Christian wrote:
Hi, Naoto. Thank you for having a look.
On 13/06/2016 14:43, Naoto Sato wrote:
On 6/13/16 1:58 PM, Brent Christian wrote:
The original Apple code then calls into
"JRSCopyCanonicalLanguageForPrimaryLanguage" to map "language" into
"language_REGION"
Hi Brent,
On 6/13/16 1:58 PM, Brent Christian wrote:
Apple suggested changing the JDK initialization order so any access to
JRS happens only after the JLI_MemAlloc symbol is available. We believe
a better solution is to re-implement the JSR APIs in question, as a move
toward eventually droppin
On 13/06/2016 16:02, Mandy Chung wrote:
I see. I’m fine with what you have. We should enhance the jlink testlibrary
to run java from a run-time image created for a test to run.
I'm okay with it too.
-Alan
> On Jun 12, 2016, at 11:10 PM, Masayoshi Okutsu
> wrote:
>
> On 6/11/2016 5:53 AM, Mandy Chung wrote:
>>> On Jun 10, 2016, at 12:08 AM, Masayoshi Okutsu
>>> wrote:
>>>
>>> (re-sending to include jigsaw-dev)
>>>
>>> Hi,
>>>
>>> Please review fixes for 8158272 and 8158468. The test had seve
Hi,
Please review the fix for JDK-8135061
Bug: https://bugs.openjdk.java.net/browse/JDK-8135061
Webrev: http://cr.openjdk.java.net/~nishjain/8135061/webrev.01/
Fix : Added a check on the lastIndexOf "-" before using substring for
truncating the extension key
Regards,
Nishit Jain
12 matches
Mail list logo
