Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

2016-06-10 Thread Mandy Chung
> On Jun 10, 2016, at 12:08 AM, Masayoshi Okutsu > wrote: > > (re-sending to include jigsaw-dev) > > Hi, > > Please review fixes for 8158272 and 8158468. The test had several problems. > > : > Webrev: > http://cr.openjdk.java.net/~okutsu/9/8158272.8158468/webrev.00 It’s good that you replac

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

2016-06-10 Thread Naoto Sato
+1. Thanks for fixing those issues. Naoto On 6/10/16 12:08 AM, Masayoshi Okutsu wrote: (re-sending to include jigsaw-dev) Hi, Please review fixes for 8158272 and 8158468. The test had several problems. - A child process doesn't inherit IO. Any outputs from the child process are not logged. -

Re: OpenJDK Governing Board CFV: New Internationalization Group Lead: Masayoshi Okutsu

2016-06-10 Thread mark . reinhold
2016/6/9 8:26:32 -0700, mark.reinh...@oracle.com: > Naoto Sato recently resigned as the Lead of the Internationalization > Group [1]. Masayoshi Okutsu was voted in as the new Group Lead shortly > thereafter [2]. > > Governing Board members: Please vote on whether to ratify this change, > as requi

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

2016-06-10 Thread Alan Bateman
On 10/06/2016 08:08, Masayoshi Okutsu wrote: (re-sending to include jigsaw-dev) Hi, Please review fixes for 8158272 and 8158468. The test had several problems. - A child process doesn't inherit IO. Any outputs from the child process are not logged. - The exit code of a child process is ig

Re: Review Request for JDK-8040211: Update LSR datafile for BCP 47

2016-06-10 Thread Yuka Kamiya
+1 On 2016/06/10 17:17, Masayoshi Okutsu wrote: Looks good to me. Masayoshi On 6/10/2016 3:20 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8040211 Bug: https://bugs.openjdk.java.net/browse/JDK-8040211 Webrev: http://cr.openjdk.java.net/~nishjain/8040211/webrev.02/ Fix: Updated

Re: Review Request for JDK-8040211: Update LSR datafile for BCP 47

2016-06-10 Thread Masayoshi Okutsu
Looks good to me. Masayoshi On 6/10/2016 3:20 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8040211 Bug: https://bugs.openjdk.java.net/browse/JDK-8040211 Webrev: http://cr.openjdk.java.net/~nishjain/8040211/webrev.02/ Fix: Updated the Language Subtag Registry data provided by IAN

RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

2016-06-10 Thread Masayoshi Okutsu
(re-sending to include jigsaw-dev) Hi, Please review fixes for 8158272 and 8158468. The test had several problems. - A child process doesn't inherit IO. Any outputs from the child process are not logged. - The exit code of a child process is ignored. The exit code needs to be checked by the t