Looks good to me.
Masayoshi
On 4/11/2016 9:18 PM, Nishit Jain wrote:
Hi,
Thanks for pointing that out.
Please review the updated webrev at the below mentioned link
http://cr.openjdk.java.net/~peytoia/Nishit/8150324/webrev.02/
Regards,
Nishit Jain
On 4/11/2016 4:46 PM, Yuka Kamiya wrote:
H
Hi,
Thanks for pointing that out.
Please review the updated webrev at the below mentioned link
http://cr.openjdk.java.net/~peytoia/Nishit/8150324/webrev.02/
Regards,
Nishit Jain
On 4/11/2016 4:46 PM, Yuka Kamiya wrote:
Hi Nishit,
Can you please replace
"jdk/src/share/classes/java/util/Curr
Hi Nishit,
Can you please replace
"jdk/src/share/classes/java/util/CurrencyData.properties" in a comment
in the test program with "jdk/make/data/currency/CurrencyData.properties" ?
Otherwise, your fix looks good to me.
Thanks,
--
Yuka
On 2016/04/11 19:55, Nishit Jain wrote:
Hello All,
Ple
Hi all,
I would like someone from java.time to do a second review for this.
Regards,
Ramanand.
-Original Message-
From: Masayoshi Okutsu
Sent: Tuesday, April 05, 2016 5:09 AM
To: Ramanand Patil; i18n-dev@openjdk.java.net
Cc: core-libs-...@openjdk.java.net
Subject: Re: RFR: 8151876: (tz)
Hello All,
Please review the following fix for JDK-8150324
Bug: https://bugs.openjdk.java.net/browse/JDK-8150324
Webrev: http://cr.openjdk.java.net/~peytoia/Nishit/8150324/webrev.01/
Fix: Tried to resolve the issue using java.time APIs to avoid problems
caused by setting the default TimeZone o
This looks okay to me.
On 11/04/2016 08:36, Masayoshi Okutsu wrote:
Hi all,
Please review the fix for JDK-8153836.
Issue:
https://bugs.openjdk.java.net/browse/JDK-8153836
Webrev:
http://cr.openjdk.java.net/~okutsu/9/8153836/webrev.00/
Thanks,
Masayoshi
Hi all,
Please review the fix for JDK-8153836.
Issue:
https://bugs.openjdk.java.net/browse/JDK-8153836
Webrev:
http://cr.openjdk.java.net/~okutsu/9/8153836/webrev.00/
Thanks,
Masayoshi
