Re: [9] RFR: 8148346: Reduce number of packages in jdk.localedata module

2016-02-18 Thread Masayoshi Okutsu
This one is much easier to take a look than the previous webrevs. This time I've looked at all diffs while I did a sampling for our internal review. Looks OK to me. I still prefer the per-language (not per-language.country) grouping, though. Masayoshi On 2/19/2016 2:50 AM, Naoto Sato wrote:

Re: Review Request for JDK-8074411: Describe "minor unit" and/or "default fraction digits" in Currency class' javadoc clearly

2016-02-18 Thread Yuka Kamiya
Hi Nishit, Your fix looks good to me. Thanks, -- Yuka On 2016/02/15 21:08, Nishit Jain wrote: Hello All, Please review the following fix in "/Currency.java/". Bug: https://bugs.openjdk.java.net/browse/JDK-8074411 Webrev: http://cr.openjdk.java.net/~rgoel/Nishit/8074411/

Re: [9] RFR: 8148346: Reduce number of packages in jdk.localedata module

2016-02-18 Thread Naoto Sato
Alan, I updated the webrev with the latest webrev tool on OpenJDK site. Here is the revised one: http://cr.openjdk.java.net/~naoto/8148346/webrev.01/ However, for some reason, the new webrev handles only .java files shuffling correctly, not for .properties files. They still remain all remov

Re: Review Request for JDK-8074411: Describe "minor unit" and/or "default fraction digits" in Currency class' javadoc clearly

2016-02-18 Thread Naoto Sato
Looks good to me. Naoto On 2/18/16 2:08 AM, Nishit Jain wrote: Hello All, Please review the updated fix in "/Currency.java/". The updated fix is located at: Webrev: http://cr.openjdk.java.net/~rgoel/Nishit/8074411/webrev.01/ Ch

Re: Review Request for JDK-8074411: Describe "minor unit" and/or "default fraction digits" in Currency class' javadoc clearly

2016-02-18 Thread Nishit Jain
Hello All, Please review the updated fix in "/Currency.java/". The updated fix is located at: Webrev: http://cr.openjdk.java.net/~rgoel/Nishit/8074411/webrev.01/ Changes made in the current version (webrev.01): Rephrasing of tex