Re: Review request for JDK-8066982: ZonedDateTime.parse() returns wrong ZoneOffset around DST fall transition

2015-12-14 Thread Roger Riggs
Hi, ok, (I still think of import is for code, not docs, but it makes the {@link}s easier). Roger On 12/14/2015 10:53 AM, Ramanand Patil wrote: RE: Review request for JDK-8066982: ZonedDateTime.parse() returns wrong ZoneOffset around DST fall transition Hi Roger, The added import in Dat

Re: Review request for JDK-8066982: ZonedDateTime.parse() returns wrong ZoneOffset around DST fall transition

2015-12-14 Thread Ramanand Patil
Hi Roger,   The added import in DateTimeFormatter.java  is because of the javadocs entry - {@link ChronoLocalDateTime#atZone(ZoneId)}     Regards, Ramanand.   From: Roger Riggs Sent: Monday, December 14, 2015 8:36 PM To: Ramanand Patil; core-libs-...@openjdk.java.net Cc: i18n-dev@openjdk.java

Re: Review request for JDK-8066982: ZonedDateTime.parse() returns wrong ZoneOffset around DST fall transition

2015-12-14 Thread Roger Riggs
Hi Ramanand, Thanks for the cleanup of the test. On 12/14/2015 3:14 AM, Ramanand Patil wrote: RE: Review request for JDK-8066982: ZonedDateTime.parse() returns wrong ZoneOffset around DST fall transition Hi Rogerand all, Please review the updated Webrev:_http://cr.openjdk.java.net/~ntv/ram

Re: Review Request: JDK-8139572 SimpleDateFormat parse month stand-alone format bug

2015-12-14 Thread Masayoshi Okutsu
Looks good to me. Masayoshi On 12/14/2015 6:29 PM, Naveen Kumar wrote: Hi All, Please review the following fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8139572 webrev: http://cr.openjdk.java.net/~okutsu/naveen/8139572/webrev.00/ issue description: SimpleDateFormat wi

Review Request: JDK-8139572 SimpleDateFormat parse month stand-alone format bug

2015-12-14 Thread Naveen Kumar
Hi All, Please review the following fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8139572 webrev: http://cr.openjdk.java.net/~okutsu/naveen/8139572/webrev.00/ issue description: SimpleDateFormat with "stand-alone" month format " " and locate ru_RU throw java.tex

Re: Review request for JDK-8066982: ZonedDateTime.parse() returns wrong ZoneOffset around DST fall transition

2015-12-14 Thread Stephen Colebourne
I remain happy with the webrev Stephen On 14 December 2015 at 08:14, Ramanand Patil wrote: > Hi Roger and all, > > Please review the updated Webrev: > http://cr.openjdk.java.net/~ntv/ramanand/8066982/webrev.02/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8066982 > > > Roger, please see my

Re: Review request for JDK-8066982: ZonedDateTime.parse() returns wrong ZoneOffset around DST fall transition

2015-12-14 Thread Stephen Colebourne
The added text and tests represent a spec clarification. The behaviour in this area was not precisely defined before. The bug itself was clear due to the expected round-trip behaviour of toString() and parse(). While this is a slightly more tricky backport than some, it is really quite broken in on

Re: Review request for JDK-8066982: ZonedDateTime.parse() returns wrong ZoneOffset around DST fall transition

2015-12-14 Thread Ramanand Patil
Hi Roger and all, Please review the updated Webrev: http://cr.openjdk.java.net/~ntv/ramanand/8066982/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8066982 Roger, please see my comments about new tests: - All my test methods were earlier generic with main method and hence had priva