Re: [9] RFR: 8141243: Unexpected timezone returned after parsing a date

2015-11-20 Thread Naoto Sato
In ResourceBundleGenerator.java, if we move "UTC" into the preferred names list, should we also treat it when we create the preferred ordered map? In other words, should we do the same for "UTC" at the line 140? Naoto On 11/20/15 12:24 AM, Masayoshi Okutsu wrote: Hello, This is a follow up o

Re: Review request :JDK-7011840:TEST_BUG java/util/Locale/LocaleEnhanceTest.java

2015-11-20 Thread Naoto Sato
Looks good to me. Naoto On 11/20/15 2:56 AM, Rachna Goel wrote: Hi all, Please review a simple fix to JDK-7011840. Extra information is outputted to report if Serialized test case data is not found. issue: https://bugs.openjdk.java.net/browse/JDK-7011840

Re: Review Request: JDK-8073211 javadoc of Format parseObject methods should specify NullPointerExceptions

2015-11-20 Thread Masayoshi Okutsu
Looks good. Masayoshi On 11/20/2015 7:20 PM, Naveen Kumar wrote: Hi, Please consider this updated webrev.01 for the review of bug JDK-8073211 Bug:https://bugs.openjdk.java.net/browse/JDK-8073211 webrev: http://cr.openjdk.java.net/~okutsu/naveen/8073211/webrev.01/ updates in

Re: Review Request: JDK-8073211 javadoc of Format parseObject methods should specify NullPointerExceptions

2015-11-20 Thread Naveen Kumar
Hi, Please consider this updated webrev.01 for the review of bug JDK-8073211 Bug:https://bugs.openjdk.java.net/browse/JDK-8073211 webrev: http://cr.openjdk.java.net/~okutsu/naveen/8073211/webrev.01/ updates in fix: Masayoshi pointed out that there was

Re: Review Request: JDK-8073211 javadoc of Format parseObject methods should specify NullPointerExceptions

2015-11-20 Thread Naveen Kumar
Hi, Please consider this updated webrev.01 for the review of bug JDK-8073211 Bug:https://bugs.openjdk.java.net/browse/JDK-8073211 webrev: http://cr.openjdk.java.net/~okutsu/naveen/8073211/webrev.01/ updates in fix: Masayoshi pointed out that there was

Review request :JDK-7011840:TEST_BUG java/util/Locale/LocaleEnhanceTest.java

2015-11-20 Thread Rachna Goel
Hi all, Please review a simple fix to JDK-7011840. Extra information is outputted to report if Serialized test case data is not found. issue: https://bugs.openjdk.java.net/browse/JDK-7011840 webrev: http://cr.openjdk.java.net/~rgoel/7011840

Re: Review Request: JDK-8073211 javadoc of Format parseObject methods should specify NullPointerExceptions

2015-11-20 Thread Yuka Kamiya
Hi, The fix looks good to me. Thanks, -- Yuka On 2015/11/20 19:20, Naveen Kumar wrote: Hi, Please consider this updated webrev.01 for the review of bug JDK-8073211 Bug:https://bugs.openjdk.java.net/browse/JDK-8073211 webrev: http://cr.openjdk.java.net/~okutsu/naveen/807321

Re: [9] RFR: 8141243: Unexpected timezone returned after parsing a date

2015-11-20 Thread Yuka Kamiya
Hi, The fix looks good to me. Thanks, -- Yuka On 2015/11/20 17:24, Masayoshi Okutsu wrote: Hello, This is a follow up of the fix for JDK-8141243 done by Ramanand. I've changed resources so that time zone ID "UTC" is picked up by SimpleDateFormat before Antarctica/Troll. issue: https://bug

[9] RFR: 8141243: Unexpected timezone returned after parsing a date

2015-11-20 Thread Masayoshi Okutsu
Hello, This is a follow up of the fix for JDK-8141243 done by Ramanand. I've changed resources so that time zone ID "UTC" is picked up by SimpleDateFormat before Antarctica/Troll. issue: https://bugs.openjdk.java.net/browse/JDK-8141243 webrev: http://cr.openjdk.java.net/~okutsu/9/8141243/web