Looks good to me.
Masayoshi
On 9/9/2015 5:33 AM, Naoto Sato wrote:
Hello,
Please review the changes for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8134384
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8134384/webrev.00/
Naoto
Christoph,
Thank you for the explanation.
Yes, the changes is reviewed.
--Dmitry
-Original Message-
From: "Langer, Christoph"
To: Dmitry Samersoff
Cc: "jdk9-...@openjdk.java.net" ,
"i18n-dev@openjdk.java.net" , Roger Riggs
Sent: Wed, 09 Sep 2015 16:08
Subject: RE: Fix for small
Hi Dmitry,
let me comment on your suggestions:
663 it might be better to use str*r*chr
-> a TZ variable could look like
TZ="MET-1METDST,M3.5.0/02:00:00,M10.5.0/03:00:00". So there could be multiple
instances of the character ',' and I'm only interested in the first part of TZ,
e.g. in "MET-1MET
Christoph,
Looks good for me.
663 it might be better to use str*r*chr
666 memcpy(tz_buf, tz, tz_len+1);
667 is not necessary
> - The part following line 323 for Solaris32 can probably be removed
> but I don't want to be the guy that does this
OK. Could you file a P4 CR to get it removed?
-Dmit
