Re: The input method handling

2014-12-10 Thread Eirik Bakke
Ah, makes sense. Thanks for the explanation. -- Eirik On 12/10/14, 2:06 PM, "Sergey Malenkov" wrote: >Thank you for the link, but my changes do not remove ability of typing >some characters. This is about internal representation of key events. >I suggest to do not replace key-typed events with

Re: The input method handling

2014-12-10 Thread Naoto Sato
Hi Sergey, It seems that the comment specifically mentions to go this route "when the string to insert is a complex Unicode value." and your change would break it. Have you investigated what it means? Also, if the change turns OK, you probably would want to change the variable name from "utf

Re: The input method handling

2014-12-10 Thread Sergey Malenkov
Thank you for the link, but my changes do not remove ability of typing some characters. This is about internal representation of key events. I suggest to do not replace key-typed events with the corresponding input method events for simple inserting of a single character. For example, with Oracle

How is thai_dict generated?

2014-12-10 Thread Tanin Na Nakorn
Hi All, I would like to understand how BreakIterator for Thai language works and am stuck at the file thai_dict. I would like to learn how it is generated. Here is the file:  https://github.com/openjdk-mirror/jdk7u-jdk/blob/master/src/share/classes/sun/text/resources/thai_dict Also, where is th

Re: The input method handling

2014-12-10 Thread Eirik Bakke
Passing by--maybe the following piece of NetBeans Platform documentation has relevance: http://wiki.netbeans.org/DevFaqLogicalKeybindings Quote: "There should be no Alt-bound keyboard shortcuts on Macintosh, ever - it is used on international keyboards as the compose key (for a long time, we did

The input method handling

2014-12-10 Thread Sergey Malenkov
Hi all, In Oracle JDK the input method handling is slightly different from Apple JDK. And this is a reason of some issues in IntelliJ IDEA. I found out that the insertText method in the following file uses lengthOfBytesUsingEncoding instead of length in characters: http://hg.openjdk.java.net/jdk9

Re: [8u40] Review request for 8065157: jdk8u40 Japanese man page file translation update

2014-12-10 Thread Michael Fang
Thank you Naoto for the review. -michael On 14年12月10日 08:58 上午, Naoto Sato wrote: Looks good to me. Naoto On 12/9/14, 7:12 PM, Michael Fang wrote: Hi, Please help to code review the changes for the following CR: 8065157: jdk8u40 Japanese man page file translation update https://bugs.openjdk

Re: [8u40] Review request for 8065157: jdk8u40 Japanese man page file translation update

2014-12-10 Thread Naoto Sato
Looks good to me. Naoto On 12/9/14, 7:12 PM, Michael Fang wrote: Hi, Please help to code review the changes for the following CR: 8065157: jdk8u40 Japanese man page file translation update https://bugs.openjdk.java.net/browse/JDK-8065157 The webrev is located at: http://cr.openjdk.java.net/~m